Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several changes to Shape class #280

Merged
merged 2 commits into from
Jan 20, 2018
Merged

Several changes to Shape class #280

merged 2 commits into from
Jan 20, 2018

Conversation

louis-langholtz
Copy link
Owner

Description - What's this PR do?

  • Changes the Shape class to make the vertex radius dependent on the child index.
  • Adds default construction to Shape class. This makes it usable for types like std::vector.

Related Issues

@louis-langholtz
Several changes:
84c19aa 
- Changes the Shape class to make the vertex radius dependent on the child index.
- Adds default construction to Shape class. This makes it usable for types like std::vector.
@louis-langholtz louis-langholtz added the Enhancement For suggestions or changes that enhance any part of the project and isn't a bug. label Jan 20, 2018
@louis-langholtz louis-langholtz added this to the Beta Launch milestone Jan 20, 2018
@louis-langholtz louis-langholtz self-assigned this Jan 20, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 98.181% when pulling 84c19aa on shape-changes-20180118 into 706269f on master.

@louis-langholtz
Two changes:
b244d8d 
- Fixes unit test for MultiShapeConf size.
- Adds unit test code to avoid loosing coverage.
@coveralls
Copy link

coveralls commented Jan 20, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 98.365% when pulling b244d8d on shape-changes-20180118 into 706269f on master.

@louis-langholtz louis-langholtz merged commit a0ecc4a into master Jan 20, 2018
@louis-langholtz louis-langholtz deleted the shape-changes-20180118 branch January 20, 2018 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@louis-langholtz louis-langholtz

Labels
Enhancement For suggestions or changes that enhance any part of the project and isn't a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-langholtz @coveralls